Removing EXE binary installers code paths and comments#2390
Merged
Avasam merged 7 commits intomhammond:mainfrom Dec 12, 2024
Merged
Removing EXE binary installers code paths and comments#2390Avasam merged 7 commits intomhammond:mainfrom
Avasam merged 7 commits intomhammond:mainfrom
Conversation
Avasam
commented
Oct 12, 2024
Avasam
commented
Oct 12, 2024
Comment on lines
+880
to
+879
| # If self.root has a value, it means we are being "installed" into some other | ||
| # directory than Python itself - in which case we must *not* run our installer. | ||
| # bdist_wininst used to trigger this by using a temp directory. | ||
| # Is this still a concern ? | ||
| if self.root: | ||
| print( | ||
| f"Not executing post install script when not installing in Python itself (self.root={self.root})" | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
As the comment says, is this still a concern? Or was this only done for the sake of an intermediate step in bdist_wininst ?
Avasam
commented
Oct 12, 2024
Avasam
force-pushed
the
Removing-EXE-binary-installers
branch
from
b01321b to
d4a92be
Compare
Avasam
force-pushed
the
Removing-EXE-binary-installers
branch
from
d4a92be to
a926c1f
Compare
mhammond
reviewed
Oct 13, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
This all seems sane to me, thanks.
…ing-EXE-binary-installers
Avasam
commented
Oct 13, 2024
Collaborator
Author
mhammond
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm leaving this as draft for now given that:Just in case we want to produce EXE installers one more time before we close deprecate exe installers #1939, despite the 307 release not currently providing themsetup.py, use a build frontend #2396 look promising !)Because of the removed conditions, hiding whitespace changes makes reviewing this a lot easier.